jmx-scraper test config sources #1750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontrib into jmx-test-config-sources
…ontrib into jmx-test-config-sources
robsunday
reviewed
Mar 6, 2025
jmx-scraper/src/integrationTest/java/io/opentelemetry/contrib/jmxscraper/JmxConnectionTest.java
Outdated
Show resolved
Hide resolved
...craper/src/integrationTest/java/io/opentelemetry/contrib/jmxscraper/JmxScraperContainer.java
Show resolved
Hide resolved
…ontrib into jmx-test-config-sources
robsunday
approved these changes
Mar 12, 2025
…ontrib into jmx-test-config-sources
|
@SylvainJuge I'll merge once merge conflict is resolved, thanks! |
…ontrib into jmx-test-config-sources
trask
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1687
Adds tests to cover all the possible ways to provide configuration for jmx-scraper:
Only the
JmxConnectionTesthas been parameterized to cover those as the connection with the remote JVM is the most complicated part as the JVM system environment need to be propagated from properties to global system properties.The test fail when we remove the
JmxScraper#propagateToSystemPropertiesmethod which handles system properties propagation.Adding those tests did not uncover any new issue, thus they help prevent any future regression.