Fix regex for EcsResource when image includes @sha256:<hash> #1789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
danielcompton
force-pushed
the
dc/fix-sha-docker-ecs
branch
from
f36038a to
7c017cf
Compare
|
@danielcompton can you sign the cla? |
Merged
|
@danielcompton can you sign the cla? |
|
Thanks, we have merged #1829 that fixes the issue. |
|
Sorry, just saw I had missed signing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This updates the regex to handle hex characters in the
@sha256portion of a Docker image URL.Existing Issue(s):
Fixes #1788
Testing:
Ran unit tests, added a new one for this image format.
Documentation:
Outstanding items: