refactor ConsistentFixedThresholdSampler to setup for dynamic alternative #2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainJuge
approved these changes
Jul 15, 2025
Contributor
SylvainJuge
left a comment
SylvainJuge
left a comment
There was a problem hiding this comment.
LGTM as a first step, looking forward to see the implementation split in two sub-classes.
trask
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Per #2016 this refactors ConsistentFixedThresholdSampler to setup for a subsequent change that allows for a fixed (final threshold) and a dynamic (volatile threshold) sampler as subclasses
Existing Issue(s):
#2016
Testing:
Tested a variant in a distribution per the issue, will repeat the full test with the final implementation when the issue is complete
Documentation:
No change needed (yet)
Outstanding items:
Refactoring to an abstract class and addition of two concrete subclasses Fixed and Dynamic