Skip to content

use mise for easier local link checking #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2025
Merged

use mise for easier local link checking #2027

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0ba204
use mise for easier local link checking
zeitlinger Jul 14, 2025
60d2e6e
pin mise
zeitlinger Jul 21, 2025
df582e8
simplify
trask Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/renovate.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,5 +212,19 @@
'"https://github.com/(?<depName>[^/]+/[^/]+)/zipball/(?<currentValue>.+?)"',
],
},
{
customType: "regex",
description: "update mise",
managerFilePatterns: [
"/(^|/)(workflow-templates|\\.(?:github|gitea|forgejo)/(?:workflows|actions))/.+\\.ya?ml$/",
"/(^|/)action\\.ya?ml$/"
],
datasourceTemplate: "github-release-attachments",
packageNameTemplate: "jdx/mise",
depNameTemplate: "mise",
matchStrings: [
"jdx/mise-action.*\\n\\s*with:\\s*\\n\\s*version: [\"']?(?<currentValue>v[.\\d]+)[\"']?\\s*\\n\\s*sha256: [\"']?(?<currentDigest>\\w+)[\"']?"
],
}
],
}
3 changes: 0 additions & 3 deletions .github/scripts/dependencies.Dockerfile
View file
Open in desktop

This file was deleted.

62 changes: 0 additions & 62 deletions .github/scripts/link-check.sh
View file
Open in desktop

This file was deleted.

11 changes: 7 additions & 4 deletions .github/workflows/reusable-link-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,15 @@ jobs:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
fetch-depth: 0 # needed for merge-base below

- uses: jdx/mise-action@bfb9fa0b029db830a8c570757cee683df207a6c5 # v2.4.0
with:
version: v2025.7.11
sha256: fe2d4c5c681c942b2f52bf0c71d04429ba4a5e090973514bde466a411190cd00
Copy link
Member

@trask trask Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed? or is it good enough without? and by removing this would it allow us to remove the custom renovate manager?

Suggested change
with:
version: v2025.7.11
sha256: fe2d4c5c681c942b2f52bf0c71d04429ba4a5e090973514bde466a411190cd00

Copy link
Member Author

@zeitlinger zeitlinger Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it failed for me a couple of times, so I'd suggest to keep it

Copy link
Member

@trask trask Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it was an old version of the action, I've pushed an update, I like to try to limit the renovate custom managers when possible b/c they're pretty confusing

- name: Link check - relative links (all files)
if: github.event_name == 'pull_request'
env:
GITHUB_TOKEN: ${{ github.token }}
run: ./.github/scripts/link-check.sh --local-links-only
run: mise run lint-local-links

- name: Get modified files
if: github.event_name == 'pull_request'
Expand Down Expand Up @@ -50,10 +53,10 @@ jobs:
if: github.event_name == 'pull_request' && steps.modified-files.outputs.files != ''
env:
GITHUB_TOKEN: ${{ github.token }}
run: ./.github/scripts/link-check.sh ${{ steps.modified-files.outputs.files }}
run: mise run lint-links ${{ steps.modified-files.outputs.files }}

- name: Link check - all links (all files)
if: github.event_name != 'pull_request' || steps.config-check.outputs.modified == 'true'
env:
GITHUB_TOKEN: ${{ github.token }}
run: ./.github/scripts/link-check.sh
run: mise run lint-links
11 changes: 11 additions & 0 deletions mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
[tools]
lychee = "0.18.1"

[tasks.lint-local-links]
run = 'lychee --verbose --scheme file --include-fragments {{arg(name="files", default=".")}}'

[tasks.lint-links]
run = 'lychee --verbose --config .github/scripts/lychee-config.toml {{arg(name="files", default=".")}}'

[settings]
idiomatic_version_file_enable_tools = []
Loading