declarative config: support Inferred spans #2030
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitlinger
force-pushed
the
inferred-spans
branch
from
b119720 to
8d60820
Compare
github-actions
bot
requested review from
JonasKunz,
SylvainJuge and
jackshirazi
|
@JonasKunz please have a look |
|
@jaydeluca please have a look |
jaydeluca
reviewed
Aug 18, 2025
...rc/test/java/io/opentelemetry/contrib/inferredspans/InferredSpansCustomizerProviderTest.java
Outdated
Show resolved
Hide resolved
...rc/test/java/io/opentelemetry/contrib/inferredspans/InferredSpansCustomizerProviderTest.java
Outdated
Show resolved
Hide resolved
|
@jaydeluca please check again |
github-actions
bot
requested review from
LikeTheSalad,
breedx-splk,
jack-berg,
srprash,
trask and
wangzlei
jaydeluca
approved these changes
Aug 18, 2025
This reverts commit 26ce159.
zeitlinger
force-pushed
the
inferred-spans
branch
from
0a1790c to
ef66353
Compare
zeitlinger
force-pushed
the
inferred-spans
branch
from
12b5e4a to
4c26526
Compare
|
🔧 The result from spotlessApply was committed to the PR branch. |
|
@jackshirazi @JonasKunz please have a look |
|
@jackshirazi @JonasKunz bump |
SylvainJuge
reviewed
Oct 23, 2025
Comment on lines
+40
to
+42
| + " backup:\n" | ||
| + " diagnostic:\n" | ||
| + " files: true\n"; |
There was a problem hiding this comment.
@jackshirazi I think we should keep backup_diagnostric_files as a single attribute, WDYT ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The declarative config bridge has been copied from the agent - eventually, we can use only one, but that's a later step.
Fixes #2029