-
Notifications
You must be signed in to change notification settings - Fork 169
Update change log for upcoming release #2043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| ## Unreleased | ||
|
|
||
| ### Consistent sampling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SylvainJuge I believe you wised to call out some breaking changes. If so please provide the language to be included in the change log.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mean about the consistent sampling ? (if yes, then maybe asking @jackshirazi might be relevant), or for marking the jmx gatherer as deprecated with #2034 ? The latter is only a documentation change for now, but if you plan to include it you can add the following:
JMX Gatherer
- JMX Gatherer is now deprecated in favor of JMX Scraper
(#2034)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe #2022 is a breaking change as in the edge case it covers, sampling will cascade correctly. But it's actually a bugfix. Nothing else that I know about is a notifiable change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant #2033
However, this should be included in the release notes as users of jmx-scraper with the following configuration will see changes in captured metrics:
otel.jmx.target.source = auto (default)
otel.jmx.target.system with jetty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I've added #2033
No description provided.