Skip to content

Conversation

@trask
Copy link
Member

@trask trask commented Jul 22, 2025

No description provided.

@trask trask requested a review from a team July 22, 2025 01:53

## Unreleased

### Consistent sampling
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SylvainJuge I believe you wised to call out some breaking changes. If so please provide the language to be included in the change log.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean about the consistent sampling ? (if yes, then maybe asking @jackshirazi might be relevant), or for marking the jmx gatherer as deprecated with #2034 ? The latter is only a documentation change for now, but if you plan to include it you can add the following:


JMX Gatherer

  • JMX Gatherer is now deprecated in favor of JMX Scraper
    (#2034)

Copy link
Contributor

@jackshirazi jackshirazi Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe #2022 is a breaking change as in the edge case it covers, sampling will cascade correctly. But it's actually a bugfix. Nothing else that I know about is a notifiable change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant #2033

However, this should be included in the release notes as users of jmx-scraper with the following configuration will see changes in captured metrics:
otel.jmx.target.source = auto (default)
otel.jmx.target.system with jetty

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I've added #2033

@laurit laurit added this pull request to the merge queue Jul 23, 2025
Merged via the queue into open-telemetry:main with commit 2434f03 Jul 23, 2025
31 checks passed
@trask trask deleted the chlog branch October 20, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants