add end to end test for declarative config for aws #2047
Conversation
|
|
||
| testImplementation("com.linecorp.armeria:armeria-junit5") | ||
| testRuntimeOnly("org.bouncycastle:bcpkix-jdk15on") | ||
| testImplementation("com.google.guava:guava") | ||
| testImplementation("org.skyscreamer:jsonassert") | ||
| testImplementation("org.junit-pioneer:junit-pioneer") |
There was a problem hiding this comment.
what is this added dependency used for?
| @@ -19,6 +24,22 @@ void providerIsLoaded() { | |||
| Iterable<ComponentProvider> providers = | |||
| ComponentLoader.forClassLoader(ResourceComponentProviderTest.class.getClassLoader()) | |||
| .load(ComponentProvider.class); | |||
| assertThat(providers).extracting(ComponentProvider::getName).containsExactly("aws"); | |||
| assertThat(providers).extracting(ComponentProvider::getName).contains("aws"); | |||
There was a problem hiding this comment.
I was curious about the need for changing containsExactly to contains so i tried to put this back to containsExactly to see what would happen, and noticed that in the test failure it lists console 3 times, plus an additional service:
Expecting actual:
["aws", "console", "console", "console", "service"]
to contain exactly (and in same order):
["aws"]
but some elements were not expected:
["console", "console", "console", "service"]
I changed the test code to get some insights into what was actually loaded to see. Looks like this is because declarative configuration is automatically adding additional console exporters for metrics and logs plus the service resource detector.
Expecting actual:
[io.opentelemetry.contrib.aws.resource.internal.AwsResourceDetector,
io.opentelemetry.exporter.logging.internal.ConsoleMetricExporterComponentProvider,
io.opentelemetry.exporter.logging.internal.ConsoleSpanExporterComponentProvider,
io.opentelemetry.exporter.logging.internal.ConsoleLogRecordExporterComponentProvider,
io.opentelemetry.sdk.extension.incubator.fileconfig.ServiceResourceDetector]
This surprised me a bit because I thought if the metric and log exporters weren't explicitly defined, they wouldn't be configured. Is my understanding off here?
See #2014 (comment)
I'll add the other cloud providers, too, if this is a good pattern.