Skip to content

Add back yaml templates used to generate the default config an example #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2025
Merged

Add back yaml templates used to generate the default config an example #2123

merged 1 commit into from
Sep 23, 2025

Conversation

@atoulme
Copy link
Contributor

@atoulme atoulme commented Aug 15, 2025

Description:

Add back the yaml template used to generate a default config file.

@atoulme atoulme requested a review from a team as a code owner August 15, 2025 22:02
@github-actions github-actions bot requested a review from breedx-splk August 15, 2025 22:02
jaydeluca
jaydeluca approved these changes Sep 10, 2025
View reviewed changes
Copy link
Member

@jaydeluca jaydeluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having a section in this component's readme that explains the different pieces of code that are maintained via weaver and templates, and how to go about regenerating them if needed etc would be helpful IMO.

Should this be updated to reference the location of the example config file added in this PR? i dont see anything in that src/main/resources/config.yml location currently

@atoulme
Copy link
Contributor Author

atoulme commented Sep 23, 2025

having a section in this component's readme that explains the different pieces of code that are maintained via weaver and templates, and how to go about regenerating them if needed etc would be helpful IMO.

OK I will file an issue.

Should this be updated to reference the location of the example config file added in this PR? i dont see anything in that src/main/resources/config.yml location currently

I'll delete that.

@breedx-splk breedx-splk added this pull request to the merge queue Sep 23, 2025
Merged via the queue into open-telemetry:main with commit 595a3ff Sep 23, 2025
31 checks passed
@atoulme atoulme mentioned this pull request Sep 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaydeluca jaydeluca jaydeluca approved these changes

@breedx-splk breedx-splk Awaiting requested review from breedx-splk

Assignees

@atoulme atoulme

@breedx-splk breedx-splk

Labels

component:ibm-mq-metrics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@atoulme @jaydeluca @breedx-splk