Add already-published option to release workflow #2165
Merged
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
approved these changes
Aug 22, 2025
breedx-splk
reviewed
Aug 22, 2025
Comment on lines
+4
to
+8
| inputs: | ||
| already-published: | ||
| description: 'Skip publishing, download artifacts from Maven Central instead' | ||
| default: false | ||
| type: boolean |
Contributor
There was a problem hiding this comment.
Just so I understand this -- this allows one to manually pass in "true" for this in order to skip the actual build+publish step when doing a release. This allows the rest of the release workflow to run to completion without failure....including the generation of release notes and the release in GH.
Is that right? Does sound useful!
Member
Author
There was a problem hiding this comment.
yup! it's useful for when it succeeds publishing but fails during creating the github release (where we introduce bugs from time-to-time)
breedx-splk
reviewed
Aug 22, 2025
Comment on lines
+153
to
+156
| curl -L -o jmx-scraper/build/libs/opentelemetry-jmx-scraper-$VERSION-alpha.jar \ | ||
| "https://repo1.maven.org/maven2/io/opentelemetry/contrib/opentelemetry-jmx-scraper/$VERSION-alpha/opentelemetry-jmx-scraper-$VERSION-alpha.jar" | ||
| curl -L -o jmx-scraper/build/libs/opentelemetry-jmx-scraper-$VERSION-alpha.jar.asc \ | ||
| "https://repo1.maven.org/maven2/io/opentelemetry/contrib/opentelemetry-jmx-scraper/$VERSION-alpha/opentelemetry-jmx-scraper-$VERSION-alpha.jar.asc" |
Contributor
There was a problem hiding this comment.
Is the scraper a new build output now? I didn't see it in 1.48 nor 1.47...
trask
added a commit
to trask/opentelemetry-java-contrib
that referenced
this pull request
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens from time to time (including this time), so this seems useful to have available.