Sync with instrumentation workflows #2168
Merged
+34
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
commented
Aug 22, 2025
| contents: read | ||
|
|
||
| jobs: | ||
| spotless: |
Member
Author
There was a problem hiding this comment.
this splits spotless out into separate job so if it fails you can still see if the other jobs succeed or fail
probably not that important anymore with the autospotless automation
UPDATE I think it's helpful after all, for people running jobs in their forks (autospotless only runs in this repo)
trask
commented
Aug 22, 2025
Comment on lines
-47
to
-48
| - macos-latest | ||
| - macos-13 |
Member
Author
There was a problem hiding this comment.
we don't test macos in instrumentation repo, I think its probably ok not to test in this repo too(?)
laurit
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.