Skip to content

Apply final to public API classes where possible - ibm-mq-metrics #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2025
Merged

Apply final to public API classes where possible - ibm-mq-metrics #2214

merged 1 commit into from
Sep 12, 2025

Conversation

@trask
Copy link
Member

@trask trask commented Sep 6, 2025

Applying the style guide section:

Public non-internal classes should be declared final where possible.

@trask trask marked this pull request as ready for review September 6, 2025 19:50
@trask trask requested a review from a team as a code owner September 6, 2025 19:50
jaydeluca
jaydeluca approved these changes Sep 10, 2025
View reviewed changes
Copy link
Member

@jaydeluca jaydeluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. cc @atoulme

@trask trask added this pull request to the merge queue Sep 12, 2025
Merged via the queue into open-telemetry:main with commit f3a54dd Sep 12, 2025
25 checks passed
@trask trask deleted the pr4-ibm-mq-metrics-final-classes branch September 12, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaydeluca jaydeluca jaydeluca approved these changes

@atoulme atoulme Awaiting requested review from atoulme

@breedx-splk breedx-splk Awaiting requested review from breedx-splk

Assignees

@atoulme atoulme

@breedx-splk breedx-splk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@trask @jaydeluca @atoulme @breedx-splk