Skip to content

Add Jackson packages grouping to Renovate configuration and fix gitignore #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 8, 2025
Merged

Add Jackson packages grouping to Renovate configuration and fix gitignore #2237

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
185fe9c
Initial plan
Copilot Sep 8, 2025
67b08ef
Initial analysis of Renovate configuration for Jackson grouping
Copilot Sep 8, 2025
d21f01f
Add Jackson packages grouping to Renovate configuration
Copilot Sep 8, 2025
bd73a56
Remove build-scan.txt and add to .gitignore
Copilot Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/renovate.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,12 @@
'com.google.errorprone{/,}**',
],
},
{
groupName: 'jackson packages',
matchPackageNames: [
'com.fasterxml.jackson{/,}**',
Copy link
Contributor

@breedx-splk breedx-splk Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this feels like copypasta (it's even in the docs), but maybe I'm missing something and I am willing to use this as a moment to learn.

Java doesn't use the forward slash in package names, so why does this glob include a forward slash?

My understanding of the brace expansion is that com.fasterxml.jackson{/,}** simply expands to com.fasterxml.jackson/** com.fasterxml.jackson**. Right?

So we don't need that first one, and the second one is probably overkill. Jackson packages are just in com.fasterxml.jackson so I'd prefer that this just tighen up to com.fasterxml.jackson. If there are other packages in the future that we want to add, we can do that then.

Suggested change
'com.fasterxml.jackson{/,}**',
'com.fasterxml.jackson',

Copy link
Member

@trask trask Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

com.fasterxml.jackson.core:jackson-databind is in com.fasterxml.jackson.core

Copy link
Contributor

@breedx-splk breedx-splk Sep 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we still be explicit then and avoid the forward slash thinger?

Suggested change
'com.fasterxml.jackson{/,}**',
'com.fasterxml.jackson',
'com.fasterxml.jackson.core',

Copy link
Member

@trask trask Sep 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking into the question about {/,}... I'm not sure (other than it's the pattern we use elsewhere in this file)...

Copy link
Member

@trask trask Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, from the Renovate logs, it looks like

"packageName": "com.fasterxml.jackson.core:jackson-databind"

can I make a follow-up PR to fix this since copilot did its job here based on our current pattern?

],
},
{
// pinned version for compatibility with java 8 JFR parsing
matchUpdateTypes: [
Expand Down
1 change: 1 addition & 0 deletions build-scan.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
https://gradle.com/s/43hywguw5f3eg