Skip to content

Fix typo #2265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2025
Merged

Fix typo #2265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c33d0e
Fix typo
laurit Sep 16, 2025
e15e043
fix test
laurit Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...a/io/opentelemetry/contrib/sampler/internal/RuleBasedRoutingSamplerComponentProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public Sampler create(DeclarativeConfigProperties config) {
fallbackSampler = DeclarativeConfiguration.createSampler(fallbackModel);
} catch (DeclarativeConfigException e) {
throw new DeclarativeConfigException(
"rule_Based_routing sampler failed to create .fallback sampler", e);
"rule_based_routing sampler failed to create .fallback sampler", e);
}

String spanKindString = config.getString("span_kind", "SERVER");
Expand Down Expand Up @@ -92,7 +92,7 @@ public Sampler create(DeclarativeConfigProperties config) {
builder.drop(attributeKey, pattern);
} else {
throw new DeclarativeConfigException(
"rule_based_routing sampler .rules[].action is must be "
"rule_based_routing sampler .rules[].action must be "
+ ACTION_RECORD_AND_SAMPLE
+ " or "
+ ACTION_DROP);
Expand Down
4 changes: 2 additions & 2 deletions samplers/src/test/java/internal/RuleBasedRoutingSamplerComponentProviderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ static Stream<Arguments> createInvalidArgs() {
+ "rules:\n"
+ " - attribute: url.path\n"
+ " pattern: path\n",
"rule_Based_routing sampler failed to create .fallback sampler"),
"rule_based_routing sampler failed to create .fallback sampler"),
Arguments.of(
"fallback_sampler:\n"
+ " always_on:\n"
Expand Down Expand Up @@ -218,6 +218,6 @@ static Stream<Arguments> createInvalidArgs() {
+ " - attribute: url.path\n"
+ " pattern: path\n"
+ " action: foo\n",
"rule_based_routing sampler .rules[].action is must be RECORD_AND_SAMPLE or DROP"));
"rule_based_routing sampler .rules[].action must be RECORD_AND_SAMPLE or DROP"));
}
}
Loading