add declarative config support for AWS X-Ray #2296
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitlinger
force-pushed
the
declarative-config-xray-sampler
branch
from
f958075 to
0f09056
Compare
laurit
reviewed
Oct 8, 2025
Comment on lines
5
to
11
| +++ NEW CLASS: PUBLIC(+) io.opentelemetry.contrib.awsxray.AwsXrayRemoteSamplerComponentProvider (not serializable) | ||
| +++ CLASS FILE FORMAT VERSION: 52.0 <- n.a. | ||
| +++ NEW SUPERCLASS: java.lang.Object | ||
| +++ NEW CONSTRUCTOR: PUBLIC(+) AwsXrayRemoteSamplerComponentProvider() | ||
| +++ NEW METHOD: PUBLIC(+) io.opentelemetry.sdk.trace.samplers.Sampler create(io.opentelemetry.api.incubator.config.DeclarativeConfigProperties) | ||
| +++ NEW METHOD: PUBLIC(+) java.lang.String getName() | ||
| +++ NEW METHOD: PUBLIC(+) java.lang.Class<io.opentelemetry.sdk.trace.samplers.Sampler> getType() |
There was a problem hiding this comment.
should these be part of the public api?
laurit
reviewed
Oct 8, 2025
|
|
||
| @Override | ||
| public Sampler create(DeclarativeConfigProperties config) { | ||
| Resource resource = io.opentelemetry.contrib.awsxray.ResourceHolder.getResource(); |
There was a problem hiding this comment.
will this work? The resource in resource holder is set from an AutoConfigurationCustomizerProvider, would that be called for declarative config?
There was a problem hiding this comment.
it does not - the test was just not catching it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-telemetry/opentelemetry-java-instrumentation#14323
Blocked: Declarative config does not offer a workaround to access the resource, which is used by this module:
opentelemetry-java-contrib/aws-xray/src/main/java/io/opentelemetry/contrib/awsxray/SamplingRuleApplier.java
Line 245 in 712ad7c
Tracking issue: open-telemetry/opentelemetry-java-instrumentation#14325