Modernize/simplify JUnit Gradle configuration #2325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
commented
Oct 1, 2025
laurit
reviewed
Oct 8, 2025
|
|
||
| testing { | ||
| suites.withType(JvmTestSuite::class).configureEach { | ||
| useJUnitJupiter() |
There was a problem hiding this comment.
what if you replaced
withType<Test>().configureEach {
useJUnitPlatform()
with useJUnitPlatform? Doing it only for suites and leaving the rest of the test tasks as they are feels a bit weird.
There was a problem hiding this comment.
sorry, I'm not following what you are suggesting to do
There was a problem hiding this comment.
oh, do you mean replacing that with useJUnitJupiter? I just tried that and it seems like useJUnitJupiter only works for test suites...
trask
force-pushed
the
modernize-junit
branch
2 times, most recently
from
f83207b to
33ef393
Compare
This was referenced Oct 10, 2025
trask
commented
Oct 17, 2025
|
|
||
| testing { | ||
| suites.withType(JvmTestSuite::class).configureEach { | ||
| useJUnitJupiter("5.13.4") |
There was a problem hiding this comment.
intentionally one version behind to verify that Renovate picks it up after merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.