Return Profiler old interval from setInterval #2354
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
setInterval() was void, but it's useful when resetting the interval to know what the previous interval was. We could add a new getInterval, but it seems more efficient to just return it from the setInterval()
Existing Issue(s):
Testing:
Documentation:
Outstanding items:
Note this technically breaks the existing InferredSpans class API, but shouldn't impact anything because existing calls to setInterval() are not assigning a return value, so will continue to work fine
Alternative Considered
We could instead add a getInterval() call