Return Profiler old interval from setInterval #2354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
reviewed
Oct 13, 2025
| @Nullable | ||
| public static Duration setProfilerInterval(Duration interval) { | ||
| InferredSpansProcessor p = instance; | ||
| if (p != null) { |
There was a problem hiding this comment.
nit: I prefer this flipped, but not a huge deal.
This would only be true when the caller is recompiled against the new api, if is is not it will fail with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
setInterval() was void, but it's useful when resetting the interval to know what the previous interval was. We could add a new getInterval, but it seems more efficient to just return it from the setInterval()
Existing Issue(s):
Testing:
Documentation:
Outstanding items:
Note this technically breaks the existing InferredSpans class API, but shouldn't impact anything because existing calls to setInterval() are not assigning a return value, so will continue to work fine
Alternative Considered
We could instead add a getInterval() call