Simplify mise task #2472
Merged
Simplify mise task #2472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
commented
Nov 24, 2025
|
|
||
| #USAGE flag "--base <base>" help="base branch to compare against (default: origin/main)" default="origin/main" | ||
| #USAGE flag "--head <head>" help="head branch to compare against (empty for local changes) (default: empty)" default="" | ||
| #USAGE flag "--event <event>" help="event name (default: pull_request)" default="pull_request" |
Member
Author
There was a problem hiding this comment.
need to leave this line to avoid breaking usages that pass in --event, will remove the line later after updating all the callers
laurit
approved these changes
Nov 25, 2025
Member
|
we could also just fix the script to only check for modifications if it's a PR, but I'm fine either way |
Merged
via the queue into
open-telemetry:main
with commit Nov 25, 2025
d651fbb
21 of 22 checks passed
trask
added a commit
to trask/opentelemetry-java
that referenced
this pull request
Nov 25, 2025
trask
added a commit
to trask/opentelemetry-java-contrib
that referenced
this pull request
Nov 25, 2025
Follow-up to open-telemetry#2472
trask
added a commit
to trask/opentelemetry-java-examples
that referenced
this pull request
Nov 25, 2025
trask
added a commit
to trask/opentelemetry-java-instrumentation
that referenced
this pull request
Nov 25, 2025
trask
added a commit
to trask/semantic-conventions-java
that referenced
this pull request
Nov 25, 2025
This was referenced Nov 25, 2025
trask
added a commit
to open-telemetry/semantic-conventions-java
that referenced
this pull request
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to simplification introduced in open-telemetry/opentelemetry-java-instrumentation#15447 (still need to go back after this is merged and remove the
--event pull_requestfrom those callers