Skip to content

Clean up ExtendedSpanBuilder call chain in HTTP Server Example #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2024
Merged

Clean up ExtendedSpanBuilder call chain in HTTP Server Example #542

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cab3d49
Clean up ExtendedSpanBuilder call chain in HTTP Server Example
illenko Dec 7, 2024
59a780a
Fix code style
illenko Dec 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions http/src/main/java/io/opentelemetry/example/http/HttpServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,12 @@ private static class HelloHandler implements HttpHandler {

@Override
public void handle(HttpExchange exchange) throws IOException {
// TODO (trask) clean up chaining after
// https://github.com/open-telemetry/opentelemetry-java/pull/6514
((ExtendedSpanBuilder)
((ExtendedSpanBuilder) tracer.spanBuilder("GET /"))
.setParentFrom(
openTelemetry.getPropagators(),
exchange.getRequestHeaders().entrySet().stream()
.collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().get(0))))
.setSpanKind(SpanKind.SERVER))
((ExtendedSpanBuilder) tracer.spanBuilder("GET /"))
.setParentFrom(
openTelemetry.getPropagators(),
exchange.getRequestHeaders().entrySet().stream()
.collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().get(0))))
.setSpanKind(SpanKind.SERVER)
.startAndRun(
() -> {
// Set the Semantic Convention
Expand Down
Loading