Skip to content

Conversation

@jaydeluca
Copy link
Member

No description provided.

@jaydeluca jaydeluca requested review from a team as code owners September 30, 2025 15:01
@jaydeluca
Copy link
Member Author

cc @zeitlinger

@jaydeluca
Copy link
Member Author

just realized this is already covered in the javaagent directory 🤦

@jaydeluca jaydeluca closed this Sep 30, 2025
@jaydeluca jaydeluca reopened this Oct 20, 2025
@jaydeluca
Copy link
Member Author

i previously closed this since the other javaagent example technically supports this, but it's not configured by default, so having a separate example specifically for declarative config seems reasonable to me. lmk what you all think about whether this makes sense to have separately or not

Copy link
Member

@zeitlinger zeitlinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

You can add an oats test - oats is already used in this project.

@trask
Copy link
Member

trask commented Oct 20, 2025

i previously closed this since the other javaagent example technically supports this, but it's not configured by default, so having a separate example specifically for declarative config seems reasonable to me. lmk what you all think about whether this makes sense to have separately or not

I think it's nice to have an example where it's enabled by default

.gitignore Outdated
Comment on lines 41 to 42
javaagent-declarative-configuration/opentelemetry-javaagent.jar
javaagent-declarative-configuration/opentelemetry-javaagent-extension.jar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could move these into javaagent-declarative-configuration/.gitignore

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the docker stuff isn't intended for users, can we move it under a testing directory of some sort?

@trask trask merged commit cfadff7 into open-telemetry:main Oct 20, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants