-
Couldn't load subscription status.
- Fork 153
Add declarative config javaagent example excluding healthcheck #833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
525e172 to
820413a
Compare
|
cc @zeitlinger |
|
just realized this is already covered in the javaagent directory 🤦 |
|
i previously closed this since the other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea!
You can add an oats test - oats is already used in this project.
I think it's nice to have an example where it's enabled by default |
547a295 to
edd9e54
Compare
.gitignore
Outdated
| javaagent-declarative-configuration/opentelemetry-javaagent.jar | ||
| javaagent-declarative-configuration/opentelemetry-javaagent-extension.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could move these into javaagent-declarative-configuration/.gitignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the docker stuff isn't intended for users, can we move it under a testing directory of some sort?
No description provided.