Skip to content

Commit 1c71575

Browse files
committed
db client metrics only makes sense with stable semconv
1 parent 0ba7177 commit 1c71575

File tree

2 files changed

+6
-2
lines changed
  • instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/db
  • instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/internal

2 files changed

+6
-2
lines changed

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/db/DbClientMetrics.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import io.opentelemetry.instrumentation.api.instrumenter.OperationListener;
1919
import io.opentelemetry.instrumentation.api.instrumenter.OperationMetrics;
2020
import io.opentelemetry.instrumentation.api.internal.OperationMetricsUtil;
21+
import io.opentelemetry.instrumentation.api.internal.SemconvStability;
2122
import java.util.concurrent.TimeUnit;
2223
import java.util.logging.Logger;
2324

@@ -44,7 +45,10 @@ public final class DbClientMetrics implements OperationListener {
4445
* @see InstrumenterBuilder#addOperationMetrics(OperationMetrics)
4546
*/
4647
public static OperationMetrics get() {
47-
return OperationMetricsUtil.create("database client", DbClientMetrics::new);
48+
if (SemconvStability.emitStableDatabaseSemconv()) {
49+
return OperationMetricsUtil.create("database client", DbClientMetrics::new);
50+
}
51+
return meter -> OperationMetricsUtil.NOOP_OPERATION_LISTENER;
4852
}
4953

5054
private final DoubleHistogram duration;

instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/internal/OperationMetricsUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
*/
2424
public class OperationMetricsUtil {
2525
private static final Logger logger = Logger.getLogger(OperationMetricsUtil.class.getName());
26-
private static final OperationListener NOOP_OPERATION_LISTENER =
26+
public static final OperationListener NOOP_OPERATION_LISTENER =
2727
new OperationListener() {
2828

2929
@Override

0 commit comments

Comments
 (0)