Skip to content

Commit 6b06ef2

Browse files
committed
db client metrics only makes sense with stable semconv
1 parent 1c71575 commit 6b06ef2

File tree

1 file changed

+4
-0
lines changed
  • instrumentation-api-incubator/src/test/java/io/opentelemetry/instrumentation/api/incubator/semconv/db

1 file changed

+4
-0
lines changed

instrumentation-api-incubator/src/test/java/io/opentelemetry/instrumentation/api/incubator/semconv/db/DbClientMetricsTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,10 @@
55

66
package io.opentelemetry.instrumentation.api.incubator.semconv.db;
77

8+
import static io.opentelemetry.instrumentation.api.internal.SemconvStability.emitStableDatabaseSemconv;
89
import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.assertThat;
910
import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.equalTo;
11+
import static org.junit.jupiter.api.Assumptions.assumeTrue;
1012

1113
import io.opentelemetry.api.common.Attributes;
1214
import io.opentelemetry.api.trace.Span;
@@ -30,6 +32,8 @@ class DbClientMetricsTest {
3032

3133
@Test
3234
void collectsMetrics() {
35+
assumeTrue(emitStableDatabaseSemconv());
36+
3337
InMemoryMetricReader metricReader = InMemoryMetricReader.create();
3438
SdkMeterProvider meterProvider =
3539
SdkMeterProvider.builder().registerMetricReader(metricReader).build();

0 commit comments

Comments
 (0)