Optimize codes

steverao · steverao · commit 93f2ffb8e813 · 2024-12-25T20:40:44.000+08:00
diff --git a/instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/TracingFilter.java b/instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/TracingFilter.java
@@ -41,12 +41,10 @@ public Result invoke(Invoker<?> invoker, Invocation invocation) {
     }
 
     Instrumenter<DubboRequest, Result> instrumenter;
-    boolean isServer = rpcContext.isProviderSide();
-    if (this.clientInstrumenter != null && this.serverInstrumenter != null) {
-      instrumenter = isServer ? serverInstrumenter : clientInstrumenter;
+    if (clientInstrumenter != null && serverInstrumenter != null) {
+      instrumenter = rpcContext.isProviderSide() ? serverInstrumenter : clientInstrumenter;
     } else {
-      instrumenter =
-          this.clientInstrumenter != null ? this.clientInstrumenter : this.serverInstrumenter;
+      instrumenter = clientInstrumenter != null ? clientInstrumenter : serverInstrumenter;
     }
 
     Context parentContext = Context.current();

Original file line number	Diff line number	Diff line change
`@@ -41,12 +41,10 @@ public Result invoke(Invoker<?> invoker, Invocation invocation) {`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`Instrumenter<DubboRequest, Result> instrumenter;`
`44`		`- boolean isServer = rpcContext.isProviderSide();`
`45`		`- if (this.clientInstrumenter != null && this.serverInstrumenter != null) {`
`46`		`- instrumenter = isServer ? serverInstrumenter : clientInstrumenter;`
	`44`	`+ if (clientInstrumenter != null && serverInstrumenter != null) {`
	`45`	`+ instrumenter = rpcContext.isProviderSide() ? serverInstrumenter : clientInstrumenter;`
`47`	`46`	`} else {`
`48`		`- instrumenter =`
`49`		`- this.clientInstrumenter != null ? this.clientInstrumenter : this.serverInstrumenter;`
	`47`	`+ instrumenter = clientInstrumenter != null ? clientInstrumenter : serverInstrumenter;`
`50`	`48`	`}`
`51`	`49`
`52`	`50`	`Context parentContext = Context.current();`