Keep old api and mark it as deprecated

Author: steverao

instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboTelemetry.java

@@ -35,13 +35,23 @@ public static DubboTelemetryBuilder builder(OpenTelemetry openTelemetry) {
     this.clientInstrumenter = clientInstrumenter;
   }
 
+  /**
+   * Returns a new Dubbo {@link Filter} that traces Dubbo RPC invocations.
+   *
+   * <p>Use {@link #newClientFilter} and {@link #newServerFilter} instead.
+   */
+  @Deprecated
+  public Filter newFilter() {
+    return new TracingFilter(serverInstrumenter, clientInstrumenter);
+  }
+
   /** Returns a new Dubbo client {@link Filter} that traces Dubbo RPC invocations. */
   public Filter newClientFilter() {
-    return new TracingFilter(clientInstrumenter, true);
+    return new TracingFilter(clientInstrumenter, null);
   }
 
   /** Returns a new Dubbo server {@link Filter} that traces Dubbo RPC invocations. */
   public Filter newServerFilter() {
-    return new TracingFilter(serverInstrumenter, false);
+    return new TracingFilter(null, serverInstrumenter);
   }
 }

instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/TracingFilter.java

@@ -18,12 +18,14 @@
 
 final class TracingFilter implements Filter {
 
-  private final Instrumenter<DubboRequest, Result> instrumenter;
-  private final boolean isClient;
+  private final Instrumenter<DubboRequest, Result> clientInstrumenter;
+  private final Instrumenter<DubboRequest, Result> serverInstrumenter;
 
-  TracingFilter(Instrumenter<DubboRequest, Result> instrumenter, boolean isClient) {
-    this.instrumenter = instrumenter;
-    this.isClient = isClient;
+  TracingFilter(
+      Instrumenter<DubboRequest, Result> clientInstrumenter,
+      Instrumenter<DubboRequest, Result> serverInstrumenter) {
+    this.clientInstrumenter = clientInstrumenter;
+    this.serverInstrumenter = serverInstrumenter;
   }
 
   @Override
@@ -38,6 +40,15 @@ public Result invoke(Invoker<?> invoker, Invocation invocation) {
       return invoker.invoke(invocation);
     }
 
+    Instrumenter<DubboRequest, Result> instrumenter;
+    boolean isServer = rpcContext.isProviderSide();
+    if (this.clientInstrumenter != null && this.serverInstrumenter != null) {
+      instrumenter = isServer ? serverInstrumenter : clientInstrumenter;
+    } else {
+      instrumenter =
+          this.clientInstrumenter != null ? this.clientInstrumenter : this.serverInstrumenter;
+    }
+
     Context parentContext = Context.current();
     DubboRequest request = DubboRequest.create((RpcInvocation) invocation, rpcContext);
 
@@ -50,7 +61,7 @@ public Result invoke(Invoker<?> invoker, Invocation invocation) {
     boolean isSynchronous = true;
     try (Scope ignored = context.makeCurrent()) {
       result = invoker.invoke(invocation);
-      if (isClient) {
+      if (instrumenter == this.clientInstrumenter) {
         CompletableFuture<Object> future = rpcContext.getCompletableFuture();
         if (future != null) {
           isSynchronous = false;