Skip to content

Commit a35cf9e

Browse files
remove commit metrics
1 parent 9498d36 commit a35cf9e

File tree

5 files changed

+6
-501
lines changed

5 files changed

+6
-501
lines changed

instrumentation/iceberg-1.8/README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,16 @@ implementation("io.opentelemetry.instrumentation:opentelemetry-iceberg-1.8:OPENT
2828

2929
### Usage
3030

31-
The instrumentation library allows creating instrumented `Scan` (e.g., `TableScan`) instances for collecting
32-
OpenTelemetry-based metrics for scans and commits. For example:
31+
The instrumentation library allows creating instrumented `Scan` (e.g., `TableScan`) instances for collecting and reporting OpenTelemetry-based sacn metrics. For example:
3332

3433
```java
35-
OpenTelemetry openTelemetry = ...
34+
OpenTelemetry openTelemetry = // ...
3635
IcebergTelemetry icebergTelemetry = IcebergTelemetry.create(openTelemetry);
3736
TableScan tableScan = icebergTelemetry.wrapScan(table.newScan());
3837

3938
try (CloseableIterable<FileScanTask> fileScanTasks = tableScan.planFiles()) {
40-
// ...
39+
// Process the scan tasks
4140
}
41+
42+
// The metrics will be reported after the scan tasks iterable is closed
4243
```

instrumentation/iceberg-1.8/library/src/main/java/io/opentelemetry/instrumentation/iceberg/v1_8/CommitMetricsBuilder.java

Lines changed: 0 additions & 266 deletions
This file was deleted.

0 commit comments

Comments
 (0)