Skip to content

Resolve memory leak in redisson instrumentation #10288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Resolve memory leak in redisson instrumentation #10288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b00b8f
Resolve Memory leak in redisson instrumentation
AlchemyDing Jan 19, 2024
eacca21
Merge branch 'refs/heads/main' into fix-redisson
AlchemyDing Jul 29, 2025
4e2d6d6
draft
AlchemyDing Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...nt/src/main/java/io/opentelemetry/javaagent/instrumentation/redisson/RedissonRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ public String getOperation() {
CommandsData commandsData = (CommandsData) command;
if (commandsData.getCommands().size() == 1) {
return commandsData.getCommands().get(0).getCommand().getName();
} else {
return "BATCH";
}
}
return null;
Expand Down
2 changes: 1 addition & 1 deletion .../io/opentelemetry/javaagent/instrumentation/redisson/AbstractRedissonAsyncClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ void atomicBatchCommand() throws ExecutionException, InterruptedException, Timeo
trace.hasSpansSatisfyingExactly(
span -> span.hasName("parent").hasKind(INTERNAL).hasNoParent(),
span ->
span.hasName("DB Query")
span.hasName("BATCH")
.hasKind(CLIENT)
.hasAttributesSatisfyingExactly(
equalTo(NETWORK_TYPE, "ipv4"),
Expand Down
4 changes: 2 additions & 2 deletions .../java/io/opentelemetry/javaagent/instrumentation/redisson/AbstractRedissonClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ void batchCommand()
trace ->
trace.hasSpansSatisfyingExactly(
span ->
span.hasName("DB Query")
span.hasName("BATCH")
.hasKind(CLIENT)
.hasAttributesSatisfyingExactly(
equalTo(NETWORK_TYPE, "ipv4"),
Expand Down Expand Up @@ -206,7 +206,7 @@ void atomicBatchCommand() {
trace.hasSpansSatisfyingExactly(
span -> span.hasName("parent").hasNoParent().hasKind(INTERNAL),
span ->
span.hasName("DB Query")
span.hasName("BATCH")
.hasKind(CLIENT)
.hasAttributesSatisfyingExactly(
equalTo(NETWORK_TYPE, "ipv4"),
Expand Down
Loading