Update the OpenTelemetry SDK version to 1.42.0 #12186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
heyams
reviewed
Sep 9, 2024
| LongCounterBuilder counterBuilder = meter.counterBuilder("test"); | ||
| assertThat(counterBuilder).isNotInstanceOf(ExtendedLongCounterBuilder.class); | ||
| assertThat(counterBuilder).isInstanceOf(ExtendedLongCounterBuilder.class); | ||
| ((ExtendedLongCounterBuilder) counterBuilder).setAttributesAdvice(emptyList()); |
There was a problem hiding this comment.
what is the purpose of this setting empty attributesAdvice?
There was a problem hiding this comment.
This test was introduced in #11934 We verified that when the underlying instrument is noop then our bridge did not implement the incubating api, because the noop instrument itself didn't implement it making bridging impossible. Now noop instruments implement the incubating api and so does our bridge, we call setAttributesAdvice as was done in #11928 to verify that this works and there are no exceptions. The argument list doesn't really matter for this test and using empty list should be fine.
| LongUpDownCounterBuilder upDownCounterBuilder = meter.upDownCounterBuilder("test"); | ||
| assertThat(upDownCounterBuilder).isNotInstanceOf(ExtendedLongUpDownCounterBuilder.class); | ||
| assertThat(upDownCounterBuilder).isInstanceOf(ExtendedLongUpDownCounterBuilder.class); | ||
| ((ExtendedLongUpDownCounterBuilder) upDownCounterBuilder).setAttributesAdvice(emptyList()); |
heyams
approved these changes
Sep 10, 2024
trask
approved these changes
Sep 12, 2024
trask
deleted the
opentelemetrybot/update-opentelemetry-sdk-to-1.42.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the OpenTelemetry SDK version to
1.42.0.