Convert couchbase tests to java #12193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
commented
Sep 9, 2024
|
|
||
| public class CouchbaseUtil { | ||
|
|
||
| public static DefaultCouchbaseEnvironment.Builder envBuilder( |
There was a problem hiding this comment.
this class is duplicated for 2.6 because the return types of methods in the builder class have changed, class compiled agains older version of the library won't work with newer version
heyams
approved these changes
Sep 9, 2024
jaydeluca
approved these changes
Sep 10, 2024
jaydeluca
reviewed
Sep 10, 2024
| @Override | ||
| public String getModuleGroup() { | ||
| return "couchbase"; | ||
| } |
There was a problem hiding this comment.
should we add the test-indy label to this PR?
There was a problem hiding this comment.
now indy tests are run by default, that is how I noticed that they failed
trask
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7195