Fix flaky couchbase tests #12262
Merged
Fix flaky couchbase tests #12262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ge.opentelemetry.io/s/xz3tis5zw7xec/tests/task/:instrumentation:couchbase:couchbase-2.6:javaagent:test/details/io.opentelemetry.javaagent.instrumentation.couchbase.v2_6.springdata.CouchbaseSpringTemplate26Test/remove(CouchbaseTemplate)%5B2%5D?expanded-stacktrace=WyIxIiwiMCJd&top-execution=1
During java conversion I made attributes that were previously optional, like
network.type, required. This made tests flaky because there is race condition in the instrumentation where virtual field could be read before the value is set on another thread. Hopefully moving setting virtual field to the start of the method resolves the issue.