Skip to content

Convert play-mvc-2.4 groovy to java #12271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 26, 2024
Merged

Convert play-mvc-2.4 groovy to java #12271

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6d109b1
Convert play-mvc-2.4 test to java
heyams Sep 17, 2024
0d55c89
Make test class package private
heyams Sep 17, 2024
1306aea
Fix spotless
heyams Sep 17, 2024
8b1f371
Convert more classes
heyams Sep 17, 2024
984439e
Temporary fix
heyams Sep 17, 2024
3d8f066
Fix connectionErrorUnopenedPortWithCallback
heyams Sep 19, 2024
2378fca
Comments
heyams Sep 26, 2024
1398d45
Fix spotless
heyams Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...st/java/io/opentelemetry/javaagent/instrumentation/play/v2_4/client/PlayWsClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,9 @@ protected void configure(HttpClientTestOptions.Builder optionsBuilder) {
return attributes;
});

optionsBuilder.setTestConnectionFailure(false);
optionsBuilder.setSpanEndsAfterType(null);

// Play HTTP client uses AsyncHttpClient internally which does not support HTTP 1.1 pipelining
// nor waiting for connection pool slots to free up. Therefore making a single connection test
// would require manually sequencing the connections, which is not meaningful for a high
Expand Down
3 changes: 3 additions & 0 deletions ...st/java/io/opentelemetry/javaagent/instrumentation/play/v2_4/client/PlayWsClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ protected void configure(HttpClientTestOptions.Builder optionsBuilder) {
optionsBuilder.setTestRedirects(false);
optionsBuilder.setTestReadTimeout(false);

optionsBuilder.setTestConnectionFailure(false);
optionsBuilder.setSpanEndsAfterType(null);

// Play HTTP client uses AsyncHttpClient internally which does not support HTTP 1.1 pipelining
// nor waiting for connection pool slots to free up. Therefore making a single connection test
// would require manually sequencing the connections, which is not meaningful for a high
Expand Down
Loading