Don't write build scan link for the test partions task #12335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydeluca
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our tests invoke gradle twice. First to figure out which tests tasks to run, using the
listTestsInPartitiontask, and after that to actually run the tasks. To make finding the build scan link easier at the end of the gradle build we write it tobuild-scan.txt. This PR skips writingbuild-scan.txtwhen thelistTestsInPartitiontask is run. Sometimes gradle publish fails in the main build and we end up havingbuild-scan.txtcontaining the link fromlistTestsInPartitionwhich is not useful, might as well not write it.