Skip to content

Conversation

@laurit
Copy link
Contributor

@laurit laurit commented Sep 26, 2024

part of #7195

@laurit laurit requested a review from a team as a code owner September 26, 2024 13:35
}
}

public static class ExceptionResource extends BaseResource {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public static class ExceptionResource extends BaseResource {
static class ExceptionResource extends BaseResource {

}
}

public static class QueryParamResource extends BaseResource {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public static class QueryParamResource extends BaseResource {
static class QueryParamResource extends BaseResource {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these need to be public so jetty can access the constructors. When testing them as package private i see the following:

18:26:18.461 [qtp1342212468-54] WARN org.eclipse.jetty.util.log - Exception while instantiating the target handler.
java.lang.NoSuchMethodException: io.opentelemetry.instrumentation.restlet.v1_1.RestletAppTestBase$QueryParamResource.()

and for PathParamResource

18:27:52.806 [qtp111210112-54] WARN org.eclipse.jetty.util.log - Exception while instantiating the target handler.
java.lang.NoSuchMethodException: io.opentelemetry.instrumentation.restlet.v1_1.RestletAppTestBase$PathParamResource.()

etc

}
}

public static class PathParamResource extends BaseResource {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public static class PathParamResource extends BaseResource {
static class PathParamResource extends BaseResource {

}
}

public static class RedirectResource extends BaseResource {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public static class RedirectResource extends BaseResource {
static class RedirectResource extends BaseResource {

}
}

public static class CaptureHeadersResource extends BaseResource {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public static class CaptureHeadersResource extends BaseResource {
static class CaptureHeadersResource extends BaseResource {

}
}

public static class IndexedChildResource extends BaseResource {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public static class IndexedChildResource extends BaseResource {
static class IndexedChildResource extends BaseResource {

@laurit laurit merged commit 68dbcd5 into open-telemetry:main Sep 27, 2024
56 checks passed
@laurit laurit deleted the restlet-1.1-java branch September 27, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants