Skip to content

Update AWS SDK request id to match semantic conventions #12352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 9, 2024
Merged

Update AWS SDK request id to match semantic conventions #12352

merged 12 commits into from
Oct 9, 2024

Conversation

@jaydeluca
Copy link
Member

@jaydeluca jaydeluca commented Sep 28, 2024 •
edited
Loading

Fixes #12311

  • The request id was not being properly added to spans in the 1.11 instrumentation, so that is fixed as well.
  • Updated the request_id attribute to be emitted by default instead of only when experimental flag is true

@jaydeluca jaydeluca requested a review from a team as a code owner September 28, 2024 14:03
@github-actions github-actions bot requested a review from theletterf September 30, 2024 09:58
@jaydeluca jaydeluca changed the title Update SQS request id to match semantic conventions Update AWS SDK request id to match semantic conventions Oct 1, 2024
@laurit laurit merged commit 2986b57 into open-telemetry:main Oct 9, 2024
56 checks passed
@pingleig pingleig mentioned this pull request Oct 9, 2024
Closed
@jaydeluca jaydeluca deleted the update-aws-sqs-request-id branch November 9, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trask trask trask left review comments

@laurit laurit laurit approved these changes

@theletterf theletterf Awaiting requested review from theletterf

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AWS SDK request id is using aws.requestId instead of aws.request_id defined in semantic conventions

3 participants

@jaydeluca @trask @laurit