Convert spymemcached test to java #12368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyams
reviewed
Sep 30, 2024
.../src/test/java/io/opentelemetry/javaagent/instrumentation/spymemcached/SpymemcachedTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/io/opentelemetry/javaagent/instrumentation/spymemcached/SpymemcachedTest.java
Outdated
Show resolved
Hide resolved
| static void setUp() { | ||
| memcachedContainer = | ||
| new GenericContainer<>("memcached:latest") | ||
| .withExposedPorts(11211) |
There was a problem hiding this comment.
please use a constant for port 11211. it's used in two places.
There was a problem hiding this comment.
imo this is not useful, other tests also don't use constants for port numbers
jaydeluca
reviewed
Sep 30, 2024
.../src/test/java/io/opentelemetry/javaagent/instrumentation/spymemcached/SpymemcachedTest.java
Outdated
Show resolved
Hide resolved
steverao
approved these changes
Oct 1, 2024
jaydeluca
approved these changes
Oct 1, 2024
jeanbisutti
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #7195