Skip to content

Make Play smoke test work on Java 17 #12464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Make Play smoke test work on Java 17 #12464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions smoke-tests/images/play/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ plugins {
id("otel.spotless-conventions")

id("com.google.cloud.tools.jib")
// TODO (trask) this plugin doesn't support Play 2.9+, see https://github.com/gradle/playframework/issues/185
// once play 3.1 is released, we can update to https://github.com/orgs/playframework/discussions/12338
id("org.gradle.playframework") version "0.14"
}

Expand All @@ -23,6 +25,10 @@ play {

dependencies {
implementation("com.typesafe.play:play-guice_$scalaVer:$playVer")
// Guice 5.1 is needed for Java 17 support on Play 2.8, see https://github.com/playframework/playframework/releases/tag/2.8.15
// TODO (trask) remove these version overrides after updating to Play 2.9
implementation("com.google.inject:guice:5.1.0")
implementation("com.google.inject.extensions:guice-assistedinject:5.1.0")
implementation("com.typesafe.play:play-logback_$scalaVer:$playVer")
implementation("com.typesafe.play:filters-helpers_$scalaVer:$playVer")
}
Expand Down
Loading