Skip to content

Pin play smoke test to guice 5 #12488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Pin play smoke test to guice 5 #12488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/renovate.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,14 @@
"matchUpdateTypes": ["major"],
"enabled": false
},
{
// intentionally pinning specifically to guice 5 in the play smoke test
// until we are able to test against the latest version of play
"matchFileNames": ["smoke-tests/images/play/build.gradle.kts"],
"matchPackagePrefixes": ["com.google.inject:", "com.google.inject.extensions:"],
"matchUpdateTypes": ["major"],
"enabled": false
},
{
// intentionally aligning both netty 4.0 and 4.1 version in this convention
"matchFileNames": ["conventions/src/main/kotlin/otel.java-conventions.gradle.kts"],
Expand Down
4 changes: 2 additions & 2 deletions smoke-tests/images/play/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ dependencies {
implementation("com.typesafe.play:play-guice_$scalaVer:$playVer")
// Guice 5.1 is needed for Java 17 support on Play 2.8, see https://github.com/playframework/playframework/releases/tag/2.8.15
// TODO (trask) remove these version overrides after updating to Play 2.9
implementation("com.google.inject:guice:7.0.0")
implementation("com.google.inject.extensions:guice-assistedinject:7.0.0")
implementation("com.google.inject:guice:5.1.0")
implementation("com.google.inject.extensions:guice-assistedinject:5.1.0")
Comment on lines -30 to +31
Copy link
Contributor

@breedx-splk breedx-splk Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two whole versions huh? Ugh. 🙈

Copy link
Member Author

@trask trask Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't try with 6.x since would have had to pin either way and long term we'll be able to remove once latest play version has gradle plugin support

implementation("com.typesafe.play:play-logback_$scalaVer:$playVer")
implementation("com.typesafe.play:filters-helpers_$scalaVer:$playVer")
}
Expand Down
Loading