Skip to content

Conversation

@shalk
Copy link
Contributor

@shalk shalk commented Nov 21, 2024

relate to #7195

@shalk shalk marked this pull request as ready for review November 25, 2024 13:03
@shalk shalk requested a review from a team as a code owner November 25, 2024 13:03
@shalk
Copy link
Contributor Author

shalk commented Nov 25, 2024

@jaydeluca i found SpringJpaTest.java is also exsist in hibernate 4.0.

https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/hibernate/hibernate-4.0/javaagent/src/test/java/spring/jpa/SpringJpaTest.java

should i need to remove flag isHibernate4 in both file ?

@trask trask merged commit 219149f into open-telemetry:main Nov 30, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants