Convert remaining aws sdk 1.11 tests from groovy to java #12777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Nov 25, 2024
Comment on lines
42
to
45
| static LocalStackContainer localStack; | ||
| private static AmazonSQSAsync sqsClient; | ||
| private static AmazonS3 s3Client; | ||
| private static AmazonSNSAsync snsClient; |
Contributor
There was a problem hiding this comment.
I think these should be instance variables as they are in the groovy test
laurit
approved these changes
Nov 25, 2024
steverao
approved these changes
Nov 25, 2024
Abhishekkr3003
pushed a commit
to Abhishekkr3003/opentelemetry-java-instrumentation
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7195