Skip to content

Conversation

@jaydeluca
Copy link
Member

Related to #12575, #12580, #12578

@jaydeluca jaydeluca requested a review from a team as a code owner November 23, 2024 13:34
@github-actions github-actions bot requested a review from theletterf November 23, 2024 13:34
@jaydeluca jaydeluca changed the title use static import for semconv attributes in tests Use static import for semconv attributes in camel tests Nov 23, 2024
- Immutable constants (where clearly named)
- Singleton instances (especially where clearly named and hopefully immutable)
- `tracer()` methods that expose tracer singleton instances
- Semantic convention attribute keys used in tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask merged commit 520fc73 into open-telemetry:main Nov 23, 2024
56 checks passed
Abhishekkr3003 pushed a commit to Abhishekkr3003/opentelemetry-java-instrumentation that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants