Skip to content

Shade testing protobuf dependency #12782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 25, 2024
Merged

Shade testing protobuf dependency #12782

merged 6 commits into from
Nov 25, 2024

Conversation

@laurit
Copy link
Contributor

@laurit laurit commented Nov 23, 2024

Supersedes #12766

@laurit laurit requested a review from a team as a code owner November 23, 2024 17:36
@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Nov 23, 2024
trask
trask approved these changes Nov 24, 2024
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to confirm my understanding, this is needed to shade our usage of com.google.protobuf so we can test our armeria instrumentation against earlier and later versions of armeria (since com.google.protobuf has breaking changes and so earlier versions of armeria don't work with later versions of com.google.protobuf)?

@laurit
Copy link
Contributor Author

laurit commented Nov 25, 2024

just to confirm my understanding, this is needed to shade our usage of com.google.protobuf so we can test our armeria instrumentation against earlier and later versions of armeria (since com.google.protobuf has breaking changes and so earlier versions of armeria don't work with later versions of com.google.protobuf)?

yes, this is need to avoid protobuf used by test harness affecting grpc tests that expect a different version of protobuf.

@laurit laurit merged commit 792b6da into open-telemetry:main Nov 25, 2024
56 checks passed
@laurit laurit deleted the shade-protobuf branch November 25, 2024 07:25
Abhishekkr3003 pushed a commit to Abhishekkr3003/opentelemetry-java-instrumentation that referenced this pull request Nov 26, 2024
@laurit @renovate @Abhishekkr3003
Shade testing protobuf dependency (open-telemetry#12782)
9e6ae75 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@laurit laurit mentioned this pull request May 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trask trask trask approved these changes

Assignees

No one assigned

Labels

test native This label can be applied to PRs to trigger them to run native tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@laurit @trask