Source dd Trace from dd artifact and update sfx to last possible. #12834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Dec 4, 2024
laurit
reviewed
Dec 5, 2024
.../src/test/java/io/opentelemetry/javaagent/instrumentation/extannotations/SayTracedHello.java
Outdated
Show resolved
Hide resolved
breedx-splk
commented
Dec 7, 2024
.../src/test/java/io/opentelemetry/javaagent/instrumentation/extannotations/SayTracedHello.java
Outdated
Show resolved
Hide resolved
…o/opentelemetry/javaagent/instrumentation/extannotations/SayTracedHello.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty silly, but I noticed that the multi-annotations test was not using the latest version of the antiquated sfx library, so I updated it. I also noticed that the dd annotation was also being sourced from the sfx artifact (since it originated as a fork), so I added the direct dd test dependency before the sfx one, so that we are using a more contemporary source.