Skip to content

Conversation

@jaydeluca
Copy link
Member

Updates tests:

  • Use waitAndAssertTraces instead of assertThat(testing.waitForTraces(1))
  • Use span.withNoParent() instead of span.hasParentSpanId(SpanId.getInvalid())
  • Use hasAttributesSatisfyingExactly instead of attributes -> assertThat(attributes).containsOnly(...
  • Use static imports where possible
  • Remove some unnecessary throws Exception

@jaydeluca jaydeluca requested a review from a team as a code owner December 24, 2024 11:45
@trask trask merged commit 02725c1 into open-telemetry:main Dec 24, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants