reuse semconv incubating attributes in test code #12992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
jaydeluca
reviewed
Jan 6, 2025
| entry(AttributeKey.stringKey("db.namespace"), "potatoes"), | ||
| entry(AttributeKey.stringKey("db.query.text"), "SELECT * FROM potato"), | ||
| entry(AttributeKey.stringKey("db.operation.name"), "SELECT")); | ||
| entry(DbIncubatingAttributes.DB_NAMESPACE, "potatoes"), |
There was a problem hiding this comment.
is there any reason not to use static imports for all of these?
There was a problem hiding this comment.
This is only to minimize the diff and keep things consistent, do you think we should migrate and use static imports like in some other files ?
There was a problem hiding this comment.
I think we could skip static imports in this file to reduce diff size. In #12920 @trask used a script to automatically add the static imports, but that script only ran under instrumentation. We could run that script in instrumentation-api-incubator in a separate PR. Use static imports in the changes that are under instrumentation, all (or at least most) of the usages should already use static imports there.
…nstrumentation into semconv-incubating
trask
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incubating semconv attributes should not be used in production code to prevent introducing compatibility issues.
However in test code the semconv attributes duplication is harmful as it makes maintenance more tedious, so this PR removes duplication for some attributes. This is not meant to be an exhaustive cleanup so leftovers are expected.