-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: support instrumentation for jsonrpc4j #13008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chenlujjj
wants to merge
17
commits into
open-telemetry:main
Choose a base branch
from
chenlujjj:feat/jsonrpc-instrumentation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0190c13
feat: support instrumentation for jsonrpc4j
chenlujjj 7781c8c
inject trace data to headers
chenlujjj b859165
fix style
chenlujjj 466971e
fix style
chenlujjj a5e1a43
resolve some comments
chenlujjj 6f50140
server span name follow convention
chenlujjj 51534a4
fix style
chenlujjj c8cd109
update supported-libraryies.md
chenlujjj c20644b
try to support proxy client
chenlujjj 527b244
update supported-libraries.md
chenlujjj 12e289d
add README.md for library
chenlujjj 974c315
support instrument proxy client
chenlujjj 06f0869
add test for proxy client
chenlujjj c5f1862
resolve some comments
chenlujjj 7972e68
move client instrumentation from library to javaagent
chenlujjj 8536218
fix failed testss
chenlujjj bfb152e
use one threadlocal in OpenTelemetryJsonRpcInvocationListener
chenlujjj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| plugins { | ||
| id("otel.javaagent-instrumentation") | ||
| } | ||
|
|
||
| muzzle { | ||
| pass { | ||
| group.set("com.github.briandilley.jsonrpc4j") | ||
| module.set("jsonrpc4j") | ||
| versions.set("[1.6,)") | ||
| assertInverse.set(true) | ||
| } | ||
| } | ||
|
|
||
| val jsonrpcVersion = "1.6" | ||
|
|
||
| dependencies { | ||
chenlujjj marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| implementation(project(":instrumentation:jsonrpc4j-1.6:library")) | ||
| implementation("com.github.briandilley.jsonrpc4j:jsonrpc4j:$jsonrpcVersion") | ||
chenlujjj marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| testImplementation(project(":instrumentation:jsonrpc4j-1.6:testing")) | ||
| } | ||
|
|
||
| tasks { | ||
| test { | ||
| systemProperty("testLatestDeps", findProperty("testLatestDeps") as Boolean) | ||
| jvmArgs("-Dotel.javaagent.experimental.thread-propagation-debugger.enabled=false") | ||
| jvmArgs("-Dotel.instrumentation.common.experimental.controller-telemetry.enabled=true") | ||
| } | ||
| } | ||
chenlujjj marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
100 changes: 100 additions & 0 deletions
100
...lemetry/javaagent/instrumentation/jsonrpc4j/v1_6/JsonRpcClientBuilderInstrumentation.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| /* | ||
| * Copyright The OpenTelemetry Authors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package io.opentelemetry.javaagent.instrumentation.jsonrpc4j.v1_6; | ||
|
|
||
| import static io.opentelemetry.javaagent.extension.matcher.AgentElementMatchers.hasClassesNamed; | ||
| import static io.opentelemetry.javaagent.extension.matcher.AgentElementMatchers.implementsInterface; | ||
| import static net.bytebuddy.matcher.ElementMatchers.isMethod; | ||
| import static net.bytebuddy.matcher.ElementMatchers.named; | ||
| import static net.bytebuddy.matcher.ElementMatchers.returns; | ||
| import static net.bytebuddy.matcher.ElementMatchers.takesArgument; | ||
| import static net.bytebuddy.matcher.ElementMatchers.takesArguments; | ||
|
|
||
| import io.opentelemetry.context.Context; | ||
| import io.opentelemetry.context.Scope; | ||
| import io.opentelemetry.instrumentation.jsonrpc4j.v1_6.HeadersSetter; | ||
| import io.opentelemetry.instrumentation.jsonrpc4j.v1_6.SimpleJsonRpcRequest; | ||
| import io.opentelemetry.instrumentation.jsonrpc4j.v1_6.SimpleJsonRpcResponse; | ||
| import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation; | ||
| import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer; | ||
| import java.util.Map; | ||
| import net.bytebuddy.asm.Advice; | ||
| import net.bytebuddy.description.type.TypeDescription; | ||
| import net.bytebuddy.matcher.ElementMatcher; | ||
|
|
||
| public class JsonRpcClientBuilderInstrumentation implements TypeInstrumentation { | ||
chenlujjj marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| @Override | ||
| public ElementMatcher<ClassLoader> classLoaderOptimization() { | ||
| return hasClassesNamed("com.googlecode.jsonrpc4j.IJsonRpcClient"); | ||
| } | ||
|
|
||
| @Override | ||
| public ElementMatcher<TypeDescription> typeMatcher() { | ||
| // match JsonRpcHttpClient and JsonRpcRestClient | ||
| return implementsInterface(named("com.googlecode.jsonrpc4j.IJsonRpcClient")); | ||
| } | ||
|
|
||
| @Override | ||
| public void transform(TypeTransformer transformer) { | ||
| transformer.applyAdviceToMethod( | ||
| isMethod() | ||
| .and(named("invoke")) | ||
| .and(takesArguments(4)) | ||
| .and(takesArgument(0, String.class)) | ||
| .and(takesArgument(1, Object.class)) | ||
| .and(takesArgument(2, named("java.lang.reflect.Type"))) | ||
| .and(takesArgument(3, named("java.util.Map"))) | ||
| .and(returns(Object.class)), | ||
| this.getClass().getName() + "$InvokeAdvice"); | ||
| } | ||
|
|
||
| @SuppressWarnings("unused") | ||
| public static class InvokeAdvice { | ||
|
|
||
| @Advice.OnMethodEnter(suppress = Throwable.class) | ||
| public static void onEnter( | ||
| @Advice.Argument(0) String methodName, | ||
| @Advice.Argument(1) Object argument, | ||
| @Advice.Argument(3) Map<String, String> extraHeaders, | ||
| @Advice.Local("otelContext") Context context, | ||
| @Advice.Local("otelScope") Scope scope) { | ||
| Context parentContext = Context.current(); | ||
| SimpleJsonRpcRequest request = new SimpleJsonRpcRequest(methodName, argument); | ||
| if (!JsonRpcSingletons.CLIENT_INSTRUMENTER.shouldStart(parentContext, request)) { | ||
chenlujjj marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| return; | ||
| } | ||
|
|
||
| context = JsonRpcSingletons.CLIENT_INSTRUMENTER.start(parentContext, request); | ||
| JsonRpcSingletons.PROPAGATORS | ||
chenlujjj marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| .getTextMapPropagator() | ||
| .inject(context, extraHeaders, HeadersSetter.INSTANCE); | ||
|
|
||
| scope = context.makeCurrent(); | ||
| } | ||
|
|
||
| @Advice.OnMethodExit(onThrowable = Throwable.class, suppress = Throwable.class) | ||
| public static void onExit( | ||
| @Advice.Argument(0) String methodName, | ||
| @Advice.Argument(1) Object argument, | ||
| @Advice.Argument(3) Map<String, String> extraHeaders, | ||
| @Advice.Return Object result, | ||
| @Advice.Thrown Throwable throwable, | ||
| @Advice.Local("otelContext") Context context, | ||
| @Advice.Local("otelScope") Scope scope) { | ||
| if (scope == null) { | ||
| return; | ||
| } | ||
|
|
||
| scope.close(); | ||
| JsonRpcSingletons.CLIENT_INSTRUMENTER.end( | ||
| context, | ||
| new SimpleJsonRpcRequest(methodName, argument), | ||
| new SimpleJsonRpcResponse(result), | ||
| throwable); | ||
| } | ||
| } | ||
| } | ||
28 changes: 28 additions & 0 deletions
28
.../opentelemetry/javaagent/instrumentation/jsonrpc4j/v1_6/JsonRpcInstrumentationModule.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| /* | ||
| * Copyright The OpenTelemetry Authors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package io.opentelemetry.javaagent.instrumentation.jsonrpc4j.v1_6; | ||
|
|
||
| import static java.util.Arrays.asList; | ||
|
|
||
| import com.google.auto.service.AutoService; | ||
| import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule; | ||
| import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation; | ||
| import java.util.List; | ||
|
|
||
| @AutoService(InstrumentationModule.class) | ||
| public class JsonRpcInstrumentationModule extends InstrumentationModule { | ||
| public JsonRpcInstrumentationModule() { | ||
| super("jsonrpc4j", "jsonrpc4j-1.6"); | ||
| } | ||
|
|
||
| @Override | ||
| public List<TypeInstrumentation> typeInstrumentations() { | ||
| return asList( | ||
| new JsonRpcServerBuilderInstrumentation(), | ||
| new JsonServiceExporterBuilderInstrumentation(), | ||
| new JsonRpcClientBuilderInstrumentation()); | ||
| } | ||
| } |
54 changes: 54 additions & 0 deletions
54
...lemetry/javaagent/instrumentation/jsonrpc4j/v1_6/JsonRpcServerBuilderInstrumentation.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| /* | ||
| * Copyright The OpenTelemetry Authors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package io.opentelemetry.javaagent.instrumentation.jsonrpc4j.v1_6; | ||
|
|
||
| import static io.opentelemetry.javaagent.extension.matcher.AgentElementMatchers.hasClassesNamed; | ||
| import static net.bytebuddy.matcher.ElementMatchers.isConstructor; | ||
| import static net.bytebuddy.matcher.ElementMatchers.named; | ||
|
|
||
| import com.googlecode.jsonrpc4j.InvocationListener; | ||
| import com.googlecode.jsonrpc4j.JsonRpcBasicServer; | ||
| import io.opentelemetry.instrumentation.api.util.VirtualField; | ||
| import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation; | ||
| import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer; | ||
| import net.bytebuddy.asm.Advice; | ||
| import net.bytebuddy.description.type.TypeDescription; | ||
| import net.bytebuddy.matcher.ElementMatcher; | ||
|
|
||
| public class JsonRpcServerBuilderInstrumentation implements TypeInstrumentation { | ||
|
|
||
| @Override | ||
| public ElementMatcher<ClassLoader> classLoaderOptimization() { | ||
| return hasClassesNamed("com.googlecode.jsonrpc4j.JsonRpcBasicServer"); | ||
| } | ||
|
|
||
| @Override | ||
| public ElementMatcher<TypeDescription> typeMatcher() { | ||
| return named("com.googlecode.jsonrpc4j.JsonRpcBasicServer"); | ||
| } | ||
|
|
||
| @Override | ||
| public void transform(TypeTransformer transformer) { | ||
| transformer.applyAdviceToMethod( | ||
| isConstructor(), this.getClass().getName() + "$ConstructorAdvice"); | ||
| } | ||
|
|
||
| @SuppressWarnings("unused") | ||
| public static class ConstructorAdvice { | ||
|
|
||
| @Advice.OnMethodExit(suppress = Throwable.class) | ||
| public static void setInvocationListener( | ||
| @Advice.This JsonRpcBasicServer jsonRpcServer, | ||
| @Advice.FieldValue("invocationListener") InvocationListener invocationListener) { | ||
| VirtualField<JsonRpcBasicServer, Boolean> instrumented = | ||
| VirtualField.find(JsonRpcBasicServer.class, Boolean.class); | ||
| if (!Boolean.TRUE.equals(instrumented.get(jsonRpcServer))) { | ||
chenlujjj marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| jsonRpcServer.setInvocationListener(JsonRpcSingletons.SERVER_INVOCATION_LISTENER); | ||
| instrumented.set(jsonRpcServer, true); | ||
| } | ||
| } | ||
| } | ||
| } | ||
33 changes: 33 additions & 0 deletions
33
...ain/java/io/opentelemetry/javaagent/instrumentation/jsonrpc4j/v1_6/JsonRpcSingletons.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| /* | ||
| * Copyright The OpenTelemetry Authors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package io.opentelemetry.javaagent.instrumentation.jsonrpc4j.v1_6; | ||
|
|
||
| import com.googlecode.jsonrpc4j.InvocationListener; | ||
| import io.opentelemetry.api.GlobalOpenTelemetry; | ||
| import io.opentelemetry.context.propagation.ContextPropagators; | ||
| import io.opentelemetry.instrumentation.api.instrumenter.Instrumenter; | ||
| import io.opentelemetry.instrumentation.jsonrpc4j.v1_6.JsonRpcTelemetry; | ||
| import io.opentelemetry.instrumentation.jsonrpc4j.v1_6.SimpleJsonRpcRequest; | ||
| import io.opentelemetry.instrumentation.jsonrpc4j.v1_6.SimpleJsonRpcResponse; | ||
|
|
||
| public final class JsonRpcSingletons { | ||
|
|
||
| public static final InvocationListener SERVER_INVOCATION_LISTENER; | ||
|
|
||
| public static final Instrumenter<SimpleJsonRpcRequest, SimpleJsonRpcResponse> CLIENT_INSTRUMENTER; | ||
|
|
||
| public static final ContextPropagators PROPAGATORS; | ||
|
|
||
| static { | ||
| JsonRpcTelemetry telemetry = JsonRpcTelemetry.builder(GlobalOpenTelemetry.get()).build(); | ||
|
|
||
| SERVER_INVOCATION_LISTENER = telemetry.newServerInvocationListener(); | ||
| CLIENT_INSTRUMENTER = telemetry.getClientInstrumenter(); | ||
| PROPAGATORS = telemetry.getPropagators(); | ||
| } | ||
|
|
||
| private JsonRpcSingletons() {} | ||
| } |
53 changes: 53 additions & 0 deletions
53
...y/javaagent/instrumentation/jsonrpc4j/v1_6/JsonServiceExporterBuilderInstrumentation.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| /* | ||
| * Copyright The OpenTelemetry Authors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package io.opentelemetry.javaagent.instrumentation.jsonrpc4j.v1_6; | ||
|
|
||
| import static io.opentelemetry.javaagent.extension.matcher.AgentElementMatchers.hasClassesNamed; | ||
| import static net.bytebuddy.matcher.ElementMatchers.isMethod; | ||
| import static net.bytebuddy.matcher.ElementMatchers.named; | ||
|
|
||
| import com.googlecode.jsonrpc4j.JsonRpcServer; | ||
| import com.googlecode.jsonrpc4j.spring.JsonServiceExporter; | ||
| import io.opentelemetry.instrumentation.api.util.VirtualField; | ||
| import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation; | ||
| import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer; | ||
| import net.bytebuddy.asm.Advice; | ||
| import net.bytebuddy.description.type.TypeDescription; | ||
| import net.bytebuddy.matcher.ElementMatcher; | ||
|
|
||
| public class JsonServiceExporterBuilderInstrumentation implements TypeInstrumentation { | ||
| @Override | ||
| public ElementMatcher<ClassLoader> classLoaderOptimization() { | ||
| return hasClassesNamed("com.googlecode.jsonrpc4j.spring.JsonServiceExporter"); | ||
| } | ||
|
|
||
| @Override | ||
| public ElementMatcher<TypeDescription> typeMatcher() { | ||
| return named("com.googlecode.jsonrpc4j.spring.JsonServiceExporter"); | ||
| } | ||
|
|
||
| @Override | ||
| public void transform(TypeTransformer transformer) { | ||
| transformer.applyAdviceToMethod( | ||
| isMethod().and(named("exportService")), this.getClass().getName() + "$ExportAdvice"); | ||
| } | ||
|
|
||
| @SuppressWarnings("unused") | ||
| public static class ExportAdvice { | ||
|
|
||
| @Advice.OnMethodExit(suppress = Throwable.class) | ||
| public static void setInvocationListener( | ||
| @Advice.This JsonServiceExporter exporter, | ||
| @Advice.FieldValue("jsonRpcServer") JsonRpcServer jsonRpcServer) { | ||
| VirtualField<JsonRpcServer, Boolean> instrumented = | ||
| VirtualField.find(JsonRpcServer.class, Boolean.class); | ||
| if (!Boolean.TRUE.equals(instrumented.get(jsonRpcServer))) { | ||
| jsonRpcServer.setInvocationListener(JsonRpcSingletons.SERVER_INVOCATION_LISTENER); | ||
chenlujjj marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| instrumented.set(jsonRpcServer, true); | ||
| } | ||
| } | ||
| } | ||
| } | ||
28 changes: 28 additions & 0 deletions
28
...test/java/io/opentelemetry/javaagent/instrumentation/jsonrpc4j/v1_6/AgentJsonRpcTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| /* | ||
| * Copyright The OpenTelemetry Authors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package io.opentelemetry.javaagent.instrumentation.jsonrpc4j.v1_6; | ||
|
|
||
| import com.googlecode.jsonrpc4j.JsonRpcBasicServer; | ||
| import io.opentelemetry.instrumentation.jsonrpc4j.v1_6.AbstractJsonRpcTest; | ||
| import io.opentelemetry.instrumentation.testing.junit.AgentInstrumentationExtension; | ||
| import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension; | ||
| import org.junit.jupiter.api.extension.RegisterExtension; | ||
|
|
||
| public class AgentJsonRpcTest extends AbstractJsonRpcTest { | ||
chenlujjj marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| @RegisterExtension | ||
| static final InstrumentationExtension testing = AgentInstrumentationExtension.create(); | ||
|
|
||
| @Override | ||
| protected InstrumentationExtension testing() { | ||
| return testing; | ||
| } | ||
|
|
||
| @Override | ||
| protected JsonRpcBasicServer configureServer(JsonRpcBasicServer server) { | ||
| return server; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| plugins { | ||
| id("otel.library-instrumentation") | ||
| } | ||
|
|
||
| val jsonrpcVersion = "1.6" | ||
| val jacksonVersion = "2.13.3" | ||
|
|
||
| dependencies { | ||
| implementation("com.github.briandilley.jsonrpc4j:jsonrpc4j:$jsonrpcVersion") | ||
chenlujjj marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| implementation("com.fasterxml.jackson.core:jackson-databind:$jacksonVersion") | ||
|
|
||
| testImplementation(project(":instrumentation:jsonrpc4j-1.6:testing")) | ||
| } | ||
19 changes: 19 additions & 0 deletions
19
.../library/src/main/java/io/opentelemetry/instrumentation/jsonrpc4j/v1_6/HeadersSetter.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| /* | ||
| * Copyright The OpenTelemetry Authors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package io.opentelemetry.instrumentation.jsonrpc4j.v1_6; | ||
|
|
||
| import io.opentelemetry.context.propagation.TextMapSetter; | ||
| import java.util.Map; | ||
|
|
||
| public enum HeadersSetter implements TextMapSetter<Map<String, String>> { | ||
| INSTANCE; | ||
|
|
||
| @Override | ||
| public void set(Map<String, String> carrier, String key, String value) { | ||
| assert carrier != null; | ||
| carrier.put(key, value); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.