Skip to content

Conversation

@xiepuhuan
Copy link
Contributor

Related to #12868

@xiepuhuan xiepuhuan requested a review from a team as a code owner January 7, 2025 17:42
@xiepuhuan
Copy link
Contributor Author

Do I need to add unit testing to GrpcRequestGetter?

@trask
Copy link
Member

trask commented Jan 8, 2025

cc @jamesmoessis

Copy link
Contributor

@jamesmoessis jamesmoessis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @xiepuhuan

I'm not overly familiar with the gRPC library, but this looks good to me. A unit test would give further confidence that multi-extraction is working. However if it has @trask's approval without the extra test I assume it's ok :)

@trask
Copy link
Member

trask commented Jan 8, 2025

A unit test would give further confidence that multi-extraction is working.

I opened #13016 to track this, @xiepuhuan wdyt?

@trask trask merged commit ae3f6ac into open-telemetry:main Jan 8, 2025
58 checks passed
@xiepuhuan
Copy link
Contributor Author

A unit test would give further confidence that multi-extraction is working.

I opened #13016 to track this, @xiepuhuan wdyt?

I will complete it immediately.

@vivvdvooren
Copy link

vivvdvooren commented Apr 3, 2025

@xiepuhuan I have been trying to use the latest version of opentelemetry-grpc-1.6 (2.14-alpha) and I get an error due to missing class io/opentelemetry/context/propagation/internal/ExtendedTextMapGetter
Which library should supply this class?

@xiepuhuan
Copy link
Contributor Author

@xiepuhuan I have been trying to use the latest version of opentelemetry-grpc-1.6 (2.14-alpha) and I get an error due to missing class io/opentelemetry/context/propagation/internal/ExtendedTextMapGetter Which library should supply this class?

io.opentelemetry:opentelemetry-context:1.48.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants