add lettuce db client metrics #13032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
just in case you didn't notice, looks like CI failures |
yeah - just digging up my memory how all this works 😉 |
steverao
reviewed
Jan 14, 2025
...ibrary/src/main/java/io/opentelemetry/instrumentation/lettuce/v5_1/OpenTelemetryTracing.java
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
test native
|
@steverao please check again |
steverao
reviewed
Jan 15, 2025
.../test/java/io/opentelemetry/javaagent/instrumentation/jdbc/test/JdbcInstrumentationTest.java
Outdated
Show resolved
Hide resolved
steverao
reviewed
Jan 15, 2025
...c/main/java/io/opentelemetry/instrumentation/lettuce/v5_1/AbstractLettuceSyncClientTest.java
Show resolved
Hide resolved
…pentelemetry/instrumentation/lettuce/v5_1/AbstractLettuceSyncClientTest.java Co-authored-by: Steve Rao <[email protected]>
…ava/io/opentelemetry/instrumentation/lettuce/v5_1/AbstractLettuceSyncClientTest.java" This reverts commit 02c35cb.
trask
reviewed
Jan 15, 2025
...c/main/java/io/opentelemetry/instrumentation/lettuce/v5_1/AbstractLettuceSyncClientTest.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Jan 15, 2025
...ary/src/main/java/io/opentelemetry/instrumentation/lettuce/v5_1/LettuceTelemetryBuilder.java
Outdated
Show resolved
Hide resolved
jaydeluca
reviewed
Jan 16, 2025
...src/main/java/io/opentelemetry/instrumentation/testing/junit/db/DbClientMetricsTestUtil.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/opentelemetry/instrumentation/lettuce/v5_1/AbstractLettuceSyncClientTest.java
Outdated
Show resolved
Hide resolved
|
@jaydeluca fixed 😄 |
trask
approved these changes
Jan 16, 2025
Comment on lines
+23
to
+25
| // db.system is required - see | ||
| // https://opentelemetry.io/docs/specs/semconv/database/database-metrics/#metric-dbclientoperationduration | ||
| assertThat(expectedKeys).extracting(AttributeKey::getKey).contains(DB_SYSTEM.getKey()); |
...ibrary/src/main/java/io/opentelemetry/instrumentation/lettuce/v5_1/OpenTelemetryTracing.java
Outdated
Show resolved
Hide resolved
...ibrary/src/main/java/io/opentelemetry/instrumentation/lettuce/v5_1/OpenTelemetryTracing.java
Show resolved
Hide resolved
jaydeluca
approved these changes
Jan 17, 2025
steverao
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12802