Skip to content

Spring starter: exclude spring routing data source from instrumentation #13054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Spring starter: exclude spring routing data source from instrumentation #13054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion ...mentation/spring/autoconfigure/internal/instrumentation/jdbc/DataSourcePostProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@

final class DataSourcePostProcessor implements BeanPostProcessor, Ordered {

private static final Class<?> ROUTING_DATA_SOURCE_CLASS = getRoutingDataSourceClass();

private final ObjectProvider<OpenTelemetry> openTelemetryProvider;
private final ObjectProvider<ConfigProperties> configPropertiesProvider;

Expand All @@ -28,11 +30,25 @@ final class DataSourcePostProcessor implements BeanPostProcessor, Ordered {
this.configPropertiesProvider = configPropertiesProvider;
}

private static Class<?> getRoutingDataSourceClass() {
try {
return Class.forName("org.springframework.jdbc.datasource.lookup.AbstractRoutingDataSource");
} catch (ClassNotFoundException exception) {
return null;
}
}

private static boolean isRoutingDatasource(Object bean) {
return ROUTING_DATA_SOURCE_CLASS != null && ROUTING_DATA_SOURCE_CLASS.isInstance(bean);
}

@CanIgnoreReturnValue
@Override
public Object postProcessAfterInitialization(Object bean, String beanName) {
// Exclude scoped proxy beans to avoid double wrapping
if (bean instanceof DataSource && !ScopedProxyUtils.isScopedTarget(beanName)) {
if (bean instanceof DataSource
&& !isRoutingDatasource(bean)
&& !ScopedProxyUtils.isScopedTarget(beanName)) {
DataSource dataSource = (DataSource) bean;
return JdbcTelemetry.builder(openTelemetryProvider.getObject())
.setStatementSanitizationEnabled(
Expand Down
Loading