Skip to content

Convert vertx-rx-java-3.5 tests to java #13117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Convert vertx-rx-java-3.5 tests to java #13117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b2b1b6
Convert vertx-rx-java-3.5 tests to java
laurit Jan 28, 2025
d470a92
address review comments
laurit Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions instrumentation/vertx/vertx-rx-java-3.5/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,11 @@ testing {
suites {
val version35Test by registering(JvmTestSuite::class) {
dependencies {
implementation("org.hsqldb:hsqldb:2.3.4")
// this only exists to make Intellij happy since it doesn't (currently at least) understand our
// inclusion of this artifact inside :testing-common
compileOnly(project.dependencies.project(":testing:armeria-shaded-for-testing", configuration = "shadow"))

implementation("org.hsqldb:hsqldb:2.3.4")
compileOnly("io.vertx:vertx-codegen:$vertxVersion")
implementation("io.vertx:vertx-web:$vertxVersion")
implementation("io.vertx:vertx-rx-java2:$vertxVersion")
Expand All @@ -42,8 +45,11 @@ testing {

val latestDepTest by registering(JvmTestSuite::class) {
dependencies {
implementation("org.hsqldb:hsqldb:2.3.4")
// this only exists to make Intellij happy since it doesn't (currently at least) understand our
// inclusion of this artifact inside :testing-common
compileOnly(project.dependencies.project(":testing:armeria-shaded-for-testing", configuration = "shadow"))

implementation("org.hsqldb:hsqldb:2.3.4")
implementation("io.vertx:vertx-web:latest.release")
implementation("io.vertx:vertx-rx-java2:latest.release")
implementation("io.vertx:vertx-web-client:latest.release")
Expand Down
219 changes: 0 additions & 219 deletions .../vertx-rx-java-3.5/javaagent/src/latestDepTest/groovy/VertxReactivePropagationTest.groovy
View file
Open in desktop

This file was deleted.

126 changes: 0 additions & 126 deletions ...a-3.5/javaagent/src/latestDepTest/groovy/client/VertxRxCircuitBreakerWebClientTest.groovy
View file
Open in desktop

This file was deleted.

Loading
Loading