Update the OpenTelemetry SDK version to 1.48.0 #13476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
Contributor
|
The changes in this PR and #13463 are currently not completely aligned. |
laurit
reviewed
Mar 10, 2025
| StructuredConfigPropertiesBridge(StructuredConfigProperties rootStructuredConfigProperties) { | ||
| instrumentationJavaNode = | ||
| rootStructuredConfigProperties | ||
| .getStructured("instrumentation", empty()) |
Contributor
There was a problem hiding this comment.
@jack-berg I had to remove this line to get the modified DeclarativeConfigPropertiesBridgeTest from https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/13463/files passing. Is this correct?
Member
There was a problem hiding this comment.
It looks correct but should rename rootStructuredConfigProperties to instrumentationNode (or equivalent).
AgentListener now obtains the DeclarativeConfigProperties representing the .instrumentation node via ConfigProvider#getInstrumentationConfig().
trask
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the OpenTelemetry SDK version to
1.48.0.