Add support for basic metadata.yaml file #13480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
trask
approved these changes
Mar 10, 2025
Comment on lines
-284
to
-314
| ### Spock | ||
|
|
||
| The `testing-common` module contains some utilities that facilitate writing Spock instrumentation | ||
| tests, such as the `InstrumentationSpecification` base class and the `LibraryTestTrait` | ||
| and `AgentTestTrait` traits. | ||
|
|
||
| Consider the following abstract test class extending `InstrumentationSpecification`: | ||
|
|
||
| ```groovy | ||
| abstract class AbstractYarpcTest extends InstrumentationSpecification { | ||
| abstract Yarpc configure(Yarpc yarpc); | ||
| def "test something"() { | ||
| // ... | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| The `InstrumentationSpecification` class contains abstract methods that are implemented by one of | ||
| our test traits in the actual test class. For example: | ||
|
|
||
| ```groovy | ||
| class LibraryYarpcTest extends AbstractYarpcTest implements LibraryTestTrait { | ||
| @Override | ||
| Yarpc configure(Yarpc yarpc) { | ||
| // register interceptor/listener etc | ||
| } | ||
| } | ||
| ``` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13468